Skip to content

test: remove globalThis.Headers skip checks#4462

Closed
Uzlopak wants to merge 1 commit intomainfrom
remove-gobalthis-headers-skip-checks
Closed

test: remove globalThis.Headers skip checks#4462
Uzlopak wants to merge 1 commit intomainfrom
remove-gobalthis-headers-skip-checks

Conversation

@Uzlopak
Copy link
Copy Markdown
Contributor

@Uzlopak Uzlopak commented Aug 25, 2025

This relates to...

Rationale

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

@Uzlopak Uzlopak changed the title test: remove globalThis.Headers skip cheks test: remove globalThis.Headers skip checks Aug 25, 2025
Copy link
Copy Markdown
Member

@KhafraDev KhafraDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's possible to disable fetch and fetch globals in node 20 still https://nodejs.org/docs/latest-v20.x/api/cli.html#--no-experimental-fetch

@Uzlopak
Copy link
Copy Markdown
Contributor Author

Uzlopak commented Aug 25, 2025

@KhafraDev

Thats a valid point. Hmm..

@Uzlopak
Copy link
Copy Markdown
Contributor Author

Uzlopak commented Aug 26, 2025

I retract this PR. When node 20 is EOL and not supported by undici, we should rip these skips out.

@Uzlopak Uzlopak closed this Aug 26, 2025
@Uzlopak Uzlopak deleted the remove-gobalthis-headers-skip-checks branch August 26, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants